fix Issue 11048 - Default arguments bypass most attributes check (pure, @safe, @nogc)#14309
Closed
ibuclaw wants to merge 4 commits intodlang:masterfrom
Closed
fix Issue 11048 - Default arguments bypass most attributes check (pure, @safe, @nogc)#14309ibuclaw wants to merge 4 commits intodlang:masterfrom
ibuclaw wants to merge 4 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14309" |
ibuclaw
force-pushed
the
issue11048
branch
2 times, most recently
from
2d8b2eb to
a441b3b
Compare
Contributor
|
This should definitely target stable |
Member
Author
This should definitely not. |
Member
Author
|
Hmm, test in issue 19645 because defaultArgSemantic eagerly folds away the cast expression. This'll need a bit more plumbing to get right. |
Contributor
|
Are you still working on this @ibuclaw ? |
Contributor
|
If possible, let the error message state that the problem is due to default values. Having the error message point to something that isn’t there is very confusing. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant on #14214 - this use of inlineCopy is exposing a hole in the
@safesystem.Checking the testsuite first, then might fold the two together.